-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add json file for Xarray Badge #10666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pierre-manchon <pierre-manchon@users.noreply.github.com>
89579b4
to
44d258d
Compare
I'm worried that the white text on that background does not pass the accessibilty contrast guidelines but im a little confused because 4a4a4a seems to be a much grayer color so im not sure why the text is showing up white |
4a4a4a is for the left side (labelColor) not the font
Font colour isn't configurable badges/shields#504 (comment) - best to just choose a different background colour if it doesn't meet accessibility requirements I think |
I found the logic in shields where they change the text color based on background and unforuntately the threshold they chose does not match up with accessibility guidelines. You can see the original verison of this PR here: https://ianhuntisaak.com/shields-color-contrast/?color=59c7d6 But an Xarray logo primary color does pass: https://ianhuntisaak.com/shields-color-contrast/?color=0e4666 as does: https://ianhuntisaak.com/shields-color-contrast/?color=b3dfe5 So a question is if we want a dark or light background (and the opposite text) |
cool! can we put it outside the root? the root is really busy already (would like to slim it down a bit more), and GH displays all root files before the readme content... |
I'm not sure the best place to put it, but sure. Maybe under "doc"? |
Add a json file for badge to the main repo (a la ruff)
See #10593
Here is it rendered:
whats-new.rst
api.rst