Allow tests to pass locally on Mac #10687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move env vars into the tests, out of the env setup. xfail tests without codec dependencies (I think this is a PyPI vs conda diff?)
github-actions
bot
added
topic-testing
Automation
- Combined error message patterns for Zarr v3 test failures - Kept both 'No group found in store' from main and 'does not exist' from local changes
dcherian
reviewed
Sep 3, 2025
| "blosc_zstd", | ||
| pytest.param( | ||
| "zstd", | ||
| marks=pytest.mark.xfail( |
There was a problem hiding this comment.
can we use explicit netCDF versions please? then it's easy to delete when we bump the min supported version
There was a problem hiding this comment.
is this re the netCDF versions though? I can look more if you have a view that it is
my initial research suggests it's about whether the codec is on the system rather than a package version
There was a problem hiding this comment.
oh yuck :( this is OK then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move env vars into the tests, out of the env setup. xfail tests without codec dependencies (I think this is a PyPI vs conda diff?)