Fix mypy errors in test_backends.py #10689
Merged
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add explicit keyword arguments to netCDF4.Dataset.createVariable calls - Add type: ignore comments for dynamic compression parameter - Remove unnecessary type: ignore for requests import These changes resolve mypy type checking errors that were causing CI failures. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes mypy type checking errors in
test_backends.pythat were causing CI failures on the main branch.Changes
varname=,datatype=,dimensions=) tonetCDF4.Dataset.createVariablecalls# type: ignore[call-overload]comments where the dynamiccompressionparameter couldn't be statically verified# type: ignore[import-untyped]for therequestsimport (type stubs are now available)Test plan
test_backends.py_check_compression_codec_availablefunction still works correctly🤖 Generated with Claude Code