Skip to content

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Sep 4, 2025

Not sure if one of the existing patterns became obsolete, though.

@keewis keewis added the run-upstream Run upstream CI label Sep 4, 2025
@keewis
Copy link
Collaborator Author

keewis commented Sep 4, 2025

looks like this has been silently fixed in #10656, so now the change from a single long string pattern to constructing the pattern dynamically is the only change in this PR

Copy link
Member

@shoyer shoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is better!

@keewis keewis merged commit 7893348 into pydata:main Sep 4, 2025
36 of 37 checks passed
@keewis keewis deleted the nightly-ci branch September 4, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-upstream Run upstream CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ Nightly upstream-dev CI failed ⚠️
3 participants