Remove mypy exclusions for test_coding_times and test_dask #10768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed test_coding_times and test_dask from mypy exclusion list - Fixed type errors in test_dask.py by adding explicit type annotations - Fixed scipy_.py type error with fallback import - Reduced type: ignore comments by using proper type hints where possible 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
dcherian
approved these changes
Sep 18, 2025
|
@pydata/xarray we now have our tests fully testing our library's type defns — we're much less likely to release code that is badly typed (...and ratcheted in, so new tests will always test the library's types) |
max-sixty
added a commit
to max-sixty/xarray
that referenced
this pull request
Sep 18, 2025
Documents the removal of all test files from mypy exclusions in PR pydata#10768. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
max-sixty
added a commit
that referenced
this pull request
Sep 18, 2025
Documents the removal of all test files from mypy exclusions in PR #10768. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <noreply@anthropic.com>
|
Amazing, well done Max!
…On Thu, Sep 18, 2025 at 10:55 AM Maximilian Roos ***@***.***> wrote:
Merged #10768 <#10768> into main.
—
Reply to this email directly, view it on GitHub
<#10768 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJJFVUPJ2JRGGI5C44QAN33TLW23AVCNFSM6AAAAACG372MXCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJZG44DEMBQHAYTGMQ>
.
You are receiving this because you are on a team that was mentioned.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes
test_coding_times.pyandtest_dask.pyfrom the mypy exclusion list and fixes all resulting type errors.Changes made
xarray.tests.test_coding_timesandxarray.tests.test_daskfrom the mypycheck_untyped_defs = falseexclusion list inpyproject.tomltest_dask.pyby:Anyfromtypingtype: ignorecomments only where necessary (e.g., intentional test of error conditions)scipy_.pyfor the fallback import caseTest plan
uv run dmypy run)🤖 Generated with Claude Code