xarray.dot to pass **kwargs to einsum #2106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shoyer sorry, late addition. |
crusaderky
changed the title
shoyer
reviewed
May 8, 2018
xarray/tests/test_computation.py
Outdated
| with pytest.raises(TypeError): | ||
| xr.dot(da_a.to_dataset(name='da'), dims='a') | ||
| with pytest.raises(TypeError): | ||
| xr.dot(dims='a') | ||
|
|
||
| # einsum parameters | ||
| xr.dot(da_a, da_b, dims=['b'], order='F') | ||
| actual = xr.dot(da_a, da_b, dims=['b']) |
There was a problem hiding this comment.
I'm a little confused here -- the result of the first line is thrown away rather than checked, and the second line doesn't use parameters at all?
There was a problem hiding this comment.
@shoyer Sorry, you're right it did not make much sense. Fixed.
stickler-ci
reviewed
May 11, 2018
xarray/tests/test_computation.py
Outdated
| assert actual.values.flags['F_CONTIGUOUS'] | ||
|
|
||
|
|
||
| # einsum has a constant string as of the first parameter, which makes |
There was a problem hiding this comment.
E303 too many blank lines (2)
|
@shoyer ready for merge if there are no further objections |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Late addition to #2089