Generalize CF encoding/decoding of datetime arrays to n-dimensions #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| or (data.dtype.kind == 'O' | ||
| and isinstance(utils.first_value(data), datetime))): | ||
| # encode datetime arrays into numeric arrays | ||
| (data, units, calendar) = utils.encode_cf_datetime( |
There was a problem hiding this comment.
as you pointed out in my pull request you should create a copy of encoding before modifying it.
|
@akleeman Thanks for your feedback, I think I've resolved all of that with my new commits. |
akleeman
added a commit
that referenced
this pull request
Mar 4, 2014
Generalize CF encoding/decoding of datetime arrays to n-dimensions
keewis
pushed a commit
to keewis/xarray
that referenced
this pull request
Jan 17, 2024
Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.4.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2.3.4...v2.4.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This will conflict with PR #40 because they both deal with handling of datetimeindex objects. Whichever goes in last will need to be rebased.