Fix Missing Imports #186
Merged
Fix Missing Imports #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a missing import that came up with I created a buildbot instance for testing OSX and Windows (building out a vm for Windows still):
https://build.pyfarm.net/builders/master-postgres-mac-2.7/builds/8/steps/run%20tests/logs/stdio
This came up because we're receiving a
BAD_REQUESTresponse on OS X which is not something we're getting on Linux and theBAD_REQUESTobject itself is not being imported. Unfortunately, the tests are still failing however (though for other reasons it appears):https://build.pyfarm.net/builders/master-postgres-mac-2.7/builds/9/steps/run%20tests/logs/stdio
The change fixes the missing import but not the general test failure since that requires further debugging and it may just be because that build slave is not setup correctly.