No support for flake8 3.0

[The-Compiler]

I just tried using this with flake8 3.0.0b1 and got:

Traceback (most recent call last):
  File "/usr/lib64/python3.5/runpy.py", line 170, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib64/python3.5/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/florian/proj/qutebrowser/git/.tox/flake8/lib/python3.5/site-packages/flake8/__main__.py", line 4, in <module>
    cli.main()
  File "/home/florian/proj/qutebrowser/git/.tox/flake8/lib/python3.5/site-packages/flake8/main/cli.py", line 16, in main
    app.run(argv)
  File "/home/florian/proj/qutebrowser/git/.tox/flake8/lib/python3.5/site-packages/flake8/main/application.py", line 292, in run
    self._run(argv)
  File "/home/florian/proj/qutebrowser/git/.tox/flake8/lib/python3.5/site-packages/flake8/main/application.py", line 278, in _run
    self.initialize(argv)
  File "/home/florian/proj/qutebrowser/git/.tox/flake8/lib/python3.5/site-packages/flake8/main/application.py", line 269, in initialize
    self.register_plugin_options()
  File "/home/florian/proj/qutebrowser/git/.tox/flake8/lib/python3.5/site-packages/flake8/main/application.py", line 149, in register_plugin_options
    self.check_plugins.register_options(self.option_manager)
  File "/home/florian/proj/qutebrowser/git/.tox/flake8/lib/python3.5/site-packages/flake8/plugins/manager.py", line 378, in register_options
    list(self.manager.map(call_register_options))
  File "/home/florian/proj/qutebrowser/git/.tox/flake8/lib/python3.5/site-packages/flake8/plugins/manager.py", line 252, in map
    yield func(self.plugins[name], *args, **kwargs)
  File "/home/florian/proj/qutebrowser/git/.tox/flake8/lib/python3.5/site-packages/flake8/plugins/manager.py", line 348, in generated_function
    return method(optmanager, *args, **kwargs)
  File "/home/florian/proj/qutebrowser/git/.tox/flake8/lib/python3.5/site-packages/flake8/plugins/manager.py", line 198, in register_options
    add_options(optmanager)
  File "/home/florian/proj/qutebrowser/git/.tox/flake8/lib/python3.5/site-packages/ebb_lint/flake8.py", line 195, in add_options
    parser.config_options.append('hard-max-line-length')
AttributeError: 'OptionManager' object has no attribute 'config_options'

flake8 documentation about the change: http://flake8.pycqa.org/en/latest/plugin-development/cross-compatibility.html#option-handling-on-flake8-2-and-3

Related fixes in pep8-naming:

PyCQA/pep8-naming@b4c3ebd
PyCQA/pep8-naming@dd623fc

[sigmavirus24]

See also: https://gitlab.com/pycqa/flake8/issues/149

[habnabit]

Ugh.

I guess I'll deal with this soon.

[sigmavirus24]

@habnabit I'm hoping to be able to help out with this and send a PR.

[The-Compiler]

I'd also like to ask you to reconsider disabling # noqa, since flake8 3.0 now supports finer-grained ignores. There's also a --disable-noqa switch to flake8 if someone wants that behaviour.

[habnabit]

@The-Compiler, sure, lack of fine-grained ignores was the reason it was disabled. Is there a way to disable blanket # noqa comments while still allowing # noqa: E123 comments?

[sigmavirus24]

@habnabit there is not unfortunately.

[habnabit]

Well then. Maybe I'll submit a patch for that if someone doesn't add it first. It's very important for me.

[sigmavirus24]

@habnabit that seems reasonable.

[markrwilliams]

#9 closes this