Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 compatibility #9

Merged
merged 4 commits into from
May 9, 2017
Merged

Flake8 compatibility #9

merged 4 commits into from
May 9, 2017

Conversation

markrwilliams
Copy link
Member

Give the people only the freshest flake8s

Means no more setup_requires, which is the worst.
This is going to make tox/coverage a little harder.
It's no longer sufficient to use just the envname.
@codecov-io
Copy link

codecov-io commented May 9, 2017

Codecov Report

Merging #9 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   99.76%   99.76%   +<.01%     
==========================================
  Files           7        9       +2     
  Lines         419      428       +9     
  Branches       88       87       -1     
==========================================
+ Hits          418      427       +9     
  Partials        1        1
Impacted Files Coverage Δ
ebb_lint/checkers/check_misc_dubious_syntax.py 100% <ø> (ø) ⬆️
ebb_lint/__init__.py 100% <100%> (ø) ⬆️
ebb_lint/_version.py 100% <100%> (ø)
ebb_lint/flake8.py 99.48% <100%> (ø) ⬆️
ebb_lint/checkers/__init__.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60a827b...c89e8ef. Read the comment docs.

@markrwilliams
Copy link
Member Author

I'm the author of the PR but not the changes, but GitHub still won't let me review them. Merging them is my approval.

@markrwilliams markrwilliams merged commit 706214d into master May 9, 2017
@markrwilliams markrwilliams deleted the flake8-compatibility branch May 9, 2017 05:52
@sigmavirus24
Copy link

👍 🍰 ✨ 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants