[READY] Merge brombo/galgebra#15 #2

utensil · 2018-09-19T01:38:22Z

merge brombo/galgebra#15 based on pygae:master and resolve conflicts literally
setup CI preliminarily
Fixes tests under Python 2
Fixes tests under Python 3

utensil · 2018-09-19T01:42:30Z

Now there're 7 fails, 13 passes, because my PR has fixed all 10 tests and merging literally has kept 10 tests with 7 fails and 3 passes from the master branch, will check and clean up later.

utensil · 2018-09-19T04:07:51Z

@hugohadfield @arsenovic I don't have the permission to set up a CI for pygae/galgebra, can you help me with the permission? Thanks.

hugohadfield · 2018-09-19T08:02:42Z

@utensil sorry I was asleep! Didn't realise I had set your permission settings wrong in the invite, you are now an owner in pygae, so hopefully you should be able to do everything you want without permission problems!

arsenovic · 2018-09-19T12:15:37Z

i gave the galgebra group to admin rights for the galgebra repo,
its under repo settings-> collaborators and team

utensil · 2018-09-20T14:07:36Z

@arsenovic @hugohadfield This PR has completed all 4 tasks and passes 12 tests under both py 2 & 3, please review, comments welcome. 😄

hugohadfield

Looks good :) Nice job Utensil!

arsenovic

i just glossed over these changes but they look good. glad to see the project start moving again.

utensil · 2018-09-21T01:24:37Z

galgebra/test_test.py

-    global n,nbar
-    Fx = HALF*((x*x)*n+2*x-nbar)
+    global n, nbar
+    Fx =  ((x * x) * n + 2 * x - nbar) / 2


Some doubts about the division here, will look into it later.

This was originally for a rational division. Better keep the HALF for now.

utensil · 2018-09-21T01:28:54Z

galgebra/mv.py

    def sort_terms(self):
-        self.terms.sort(key=operator.itemgetter(1), cmp=Pdop.compare)
+        # self.terms.sort(key=operator.itemgetter(1))
+        self.terms.sort(key=cmp_to_key(Pdop.compare))


It was using both key and cmp, and the cmp obviously contains more logics which I chose to keep instead of key.

utensil · 2018-09-21T01:30:16Z

setup.py

+    sys.argv.remove('--noconflict')
+except Exception as e:
+    pass
+ga_namespace = 'galgebra' if noconflict else ''


These are probably obsolete.

utensil · 2018-09-21T01:38:24Z

Thanks, then I'll merge after some small revision 😃

Here's a little change log besides changes in brombo/galgebra#15 :

.travis.yml: runs test_test.py and test_mv.py for py 2.7 & 3.6 using py.test, no coverage yet, installation is done by python setup.py install instead of setting pth
change the way of importing modules to make it compatible with both py 2 & 3, circular dependencies removed (except a few helper functions depending on them which can be at a better place or removed later)
- use from . import in modules
- use from galgebra.ga import-ish in tests
- remove self-dependencies and the circular dependencies between mv and ga
fix illegal escape sequence warning by adding r prefix to strings with LaTeX in it
fix most of py3 compatiblity issues by 2to3 and __future__ imports
manually fix the following py3 compatibility issues:
- make string type checking work under both 2 and 3 without importing unicode_literals from __future__
- add a naive compiler.ast. flatten implementation to make it work under 3 (it's gone since 3)
- fix Sdop.sort_terms by using key function with the help of functools.cmp_to_key (cmp is gone since 3)
- fix bugs in _print_Derivative implementation in GaPrinter when handling the variables and the powers of them
.gitignore: add a few more file types

utensil added 23 commits May 8, 2016 18:23

Remove .pyc files and add standard .gitignore for python

4866352

A minimal setup.py that works

2d6606e

Add option --noconflict

7ec591e

Make setuptools recognize tests

907c920

Bypass test_test to run test_mv

bfe9064

Pass test_basic_multivector_operations

3c25e96

Pass check_generalized_BAC_CAB_formulas with failed simplification

271897a

Print_Function() is not required

0b97cac

(a|(b^c))+(c|(a^b))+(b|(c^a)).simplify() => 0

7b9425e

Pass test_derivatives_in_rectangular_coordinates

d3d8153

Postpone 3 cases to pass test_derivatives_in_spherical_coordinates

df77bfa

Verified and pass grad|A

c992cae

Verified -s3d.I()*(grad^A)

eb254e6

Verified grad^B but found a print_latex bug

7347fb0

Pass test_rounding_numerical_components

b646014

Pass test_noneuclidian_distance_calculation with postponed tests

efe76f4

Merge branch 'master' of https://github.com/brombo/galgebra into 14-pip

498a16b

Pass the rest of tests

7abb105

Code clean up

50cb844

Fixes pygae#19

6f01094

Fixes pygae#20

10a16cc

git pull upstream master and resolve conflicts

ba2230e

Merge brombo/galgebra#15 and resolve conflicts

abe1a00

Run 2to3 -w *.py

8d55fa4

utensil added 2 commits September 19, 2018 13:16

Pass tests under py3

97612fe

Add .travis.yml

db89f83

utensil force-pushed the 15-pip branch from 34f6577 to db89f83 Compare September 19, 2018 05:17

Add "from __future__ import" triple

01c9d7b

utensil force-pushed the 15-pip branch 2 times, most recently from b7a0500 to 01c9d7b Compare September 19, 2018 12:11

utensil added 3 commits September 20, 2018 09:03

Remove cirular dependencies

2838a1c

Verify and remove old tests

3a81bbd

Accept equivalent results

d4c5efd

utensil force-pushed the 15-pip branch from 3409b68 to d4c5efd Compare September 20, 2018 01:30

utensil added 2 commits September 20, 2018 21:06

Fix more py3 tests

4c41528

Fix py2 tests

b4a3672

utensil force-pushed the 15-pip branch from c805574 to b4a3672 Compare September 20, 2018 13:56

Pass both py 2 & 3 tests

582f8a1

utensil changed the title ~~[DON't MERGE YET] Merge brombo/galgebra#15~~ [READY] Merge brombo/galgebra#15 Sep 20, 2018

utensil requested a review from hugohadfield September 20, 2018 14:05

utensil self-assigned this Sep 20, 2018

utensil requested a review from arsenovic September 20, 2018 14:07

hugohadfield approved these changes Sep 20, 2018

View reviewed changes

arsenovic reviewed Sep 20, 2018

View reviewed changes

utensil commented Sep 21, 2018

View reviewed changes

utensil added 2 commits September 21, 2018 13:26

Revert to using the legacy Rational HALF

3a29736

Clean up obsolete code in setup.py and make it simple

0f7c76c

utensil merged commit 7c664a1 into pygae:master Sep 21, 2018

utensil mentioned this pull request Sep 21, 2018

Fix and close lingering issues in brombo/galgebra #4

Closed

19 tasks

utensil mentioned this pull request Feb 14, 2019

0.4.3 release #11

Merged

5 tasks

eric-wieser mentioned this pull request Dec 4, 2019

Make galgebra pip-installable (brombo/galgebra#14) #107

Closed

Greg1950 mentioned this pull request Sep 12, 2020

Method .matrix() in module lt.py returns incorrect matrices; suggested correction; method .det() returns incorrect determinant #453

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[READY] Merge brombo/galgebra#15 #2

[READY] Merge brombo/galgebra#15 #2

Uh oh!

utensil commented Sep 19, 2018 •

edited

Loading

Uh oh!

utensil commented Sep 19, 2018 •

edited

Loading

Uh oh!

utensil commented Sep 19, 2018

Uh oh!

hugohadfield commented Sep 19, 2018

Uh oh!

arsenovic commented Sep 19, 2018

Uh oh!

utensil commented Sep 20, 2018

Uh oh!

hugohadfield left a comment

Uh oh!

arsenovic left a comment

Uh oh!

utensil Sep 21, 2018

Uh oh!

utensil Sep 21, 2018

Uh oh!

utensil Sep 21, 2018 •

edited

Loading

Uh oh!

utensil Sep 21, 2018

Uh oh!

utensil commented Sep 21, 2018 •

edited

Loading

Uh oh!

Uh oh!

[READY] Merge brombo/galgebra#15 #2

[READY] Merge brombo/galgebra#15 #2

Uh oh!

Conversation

utensil commented Sep 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

utensil commented Sep 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

utensil commented Sep 19, 2018

Uh oh!

hugohadfield commented Sep 19, 2018

Uh oh!

arsenovic commented Sep 19, 2018

Uh oh!

utensil commented Sep 20, 2018

Uh oh!

hugohadfield left a comment

Choose a reason for hiding this comment

Uh oh!

arsenovic left a comment

Choose a reason for hiding this comment

Uh oh!

utensil Sep 21, 2018

Choose a reason for hiding this comment

Uh oh!

utensil Sep 21, 2018

Choose a reason for hiding this comment

Uh oh!

utensil Sep 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

utensil Sep 21, 2018

Choose a reason for hiding this comment

Uh oh!

utensil commented Sep 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

utensil commented Sep 19, 2018 •

edited

Loading

utensil commented Sep 19, 2018 •

edited

Loading

utensil Sep 21, 2018 •

edited

Loading

utensil commented Sep 21, 2018 •

edited

Loading