PATCH: pygame.scrap on X11, fix copying into PRIMARY selection (208)

[GalacticEmperor1]

Issue №208 opened by illume at 2014-09-12 09:36:06

Originally reported by: Rob Hagemans (Bitbucket: robhagemans, GitHub: robhagemans)

---

Copying into theX11 PRIMARY selection (mouse copy/paste) would not work due to a confusion between content type and clipboard type. Short patch for src/scrap_x11.c from svn below.
NB: Not sure if this is the proper forum for submitting a patch but the pygame.org mailing list subscription page is offline.

# !c


768c768
<         if (cliptype == XA_PRIMARY)
---
>         if (clip == XA_PRIMARY)
774c774
<         timestamp = (cliptype == XA_PRIMARY) ? _selectiontime : _cliptime;
---
>         timestamp = (clip == XA_PRIMARY) ? _selectiontime : _cliptime;

---

• Bitbucket: https://bitbucket.org/pygame/pygame/issue/208

---

Comments

# # illume commented at 2014-09-12 09:37:39

Original comment by Rob Hagemans (Bitbucket: robhagemans, GitHub: robhagemans):

---

Edited for formatting

---

# # illume commented at 2014-09-12 09:43:37

Original comment by Rob Hagemans (Bitbucket: robhagemans, GitHub: robhagemans):

---

Patch in diff -u format

---

# # illume commented at 2015-10-25 00:26:50

Original comment by Lenard Lindstrom (Bitbucket: llindstrom, GitHub: llindstrom):

---

Will need to research scrap library before applying the patch.

---

# # illume commented at 2015-10-26 07:01:47

Original comment by Rob Hagemans (Bitbucket: robhagemans, GitHub: robhagemans):

---

Thanks! Let me know what I can do to help.

---

# # illume commented at 2015-11-11 23:56:53

Original comment by Lenard Lindstrom (Bitbucket: llindstrom, GitHub: llindstrom):

---

Close issue # 208

Apply the patch provided by Rob Hagemans (Thanks). Include an interactive
unit test for X11 only.

---

# # illume commented at 2017-01-11 10:21:41

Original comment by Thomas Kluyver (Bitbucket: takluyver, GitHub: takluyver):

---

Removing version: svn (automated comment)