Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file comment header titles #2013

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Update file comment header titles #2013

merged 3 commits into from
Mar 13, 2023

Conversation

simplyrohan
Copy link
Contributor

Fixes: #2006

Updates title from old pygame title in the codebase to pygame-ce in font.c.

@simplyrohan simplyrohan requested a review from a team as a code owner March 12, 2023 03:21
@yunline
Copy link
Contributor

yunline commented Mar 12, 2023

image
Humm, it seems there are 79 else.

@MyreMylar
Copy link
Member

MyreMylar commented Mar 12, 2023

@simplyrohan Do you want to fix all of these headers or are you happy stopping here?

Probably we should decide on a standard modern copyright header, if we are going to have one, and exclude the year. e.g.

/*
    pygame-ce - Pygame Community Edition Library
    Copyright (C) The Pygame Community Edition Contributors.

    Based on the Pygame library, originally created by Pete Shinners

    This library is free software; you can redistribute it and/or
    modify it under the terms of the GNU Library General Public
    License as published by the Free Software Foundation; either
    version 2 of the License, or (at your option) any later version.

    This library is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
    Library General Public License for more details.

    You should have received a copy of the GNU Library General Public
    License along with this library; if not, write to the Free
    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA

    Website: https://pyga.me/
*/

@simplyrohan
Copy link
Contributor Author

simplyrohan commented Mar 12, 2023

@novialriptide told me this, and I am making a commit at the moment. I thought the headers had already been changed and we simply forgot this one.

Also, I agree that we need to redo the copyright header. But for now, I will just change the title header. Also, @MyreMylar , I have some changes that I haven't committed that also retitle in other places than comment headers (Log messages, comments other than headers, etc). Let me know if you want those, or if I should stop at the title headers.

@simplyrohan simplyrohan changed the title Update comment heading in draw.c Update file comment header titles Mar 12, 2023
Copy link
Member

@novialriptide novialriptide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itzpr3d4t0r itzpr3d4t0r added the Formatting typos, grammar etc. label Mar 12, 2023
@itzpr3d4t0r itzpr3d4t0r added this to the 2.2 milestone Mar 12, 2023
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, LGTM 👍

@MyreMylar MyreMylar merged commit 793d2de into pygame-community:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Formatting typos, grammar etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pygame is still mentioned in the codebase
5 participants