Skip to content

Conversation

Starbuck5
Copy link
Member

@Starbuck5 Starbuck5 commented Jun 7, 2025

Also updates libdrm because the old setup was failing to build.

@Starbuck5 Starbuck5 requested a review from a team as a code owner June 7, 2025 08:50
@Starbuck5 Starbuck5 marked this pull request as draft June 7, 2025 09:41
@Starbuck5
Copy link
Member Author

Starbuck5 commented Jun 7, 2025

I'm unsure how to deal with drm failure @ankith26.

We could move 123->124 and update the checksum?
We could complain to them that their release changed? Do we think it's a security issue?

@ankith26
Copy link
Member

ankith26 commented Jun 7, 2025

I don't think they changed the release file, its more likely that it was just some network issue or something else that lead to this. We can try doing a rerun in a few hours/days and seeing if this issue persists

@Starbuck5
Copy link
Member Author

I checked locally several attempts, the file hash does not match.

@ankith26
Copy link
Member

ankith26 commented Jun 7, 2025

You are right... the hash did actually change. I extracted the archive and yes, the name of the top level folder definitely changed.

We could move 123->124 and update the checksum?

I think this makes sense.

@Starbuck5 Starbuck5 force-pushed the starbuck-SDL-2.32.8 branch 2 times, most recently from 45c3375 to f703a49 Compare June 8, 2025 09:05
Previous one failed hash checks because they renamed a folder (apparently?).
@Starbuck5 Starbuck5 force-pushed the starbuck-SDL-2.32.8 branch from f703a49 to fcfd235 Compare June 8, 2025 09:11
@Starbuck5 Starbuck5 marked this pull request as ready for review June 8, 2025 09:47
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oddbookworm oddbookworm added this to the 2.5.6 milestone Jun 9, 2025
@oddbookworm oddbookworm merged commit 0779af7 into main Jun 9, 2025
26 checks passed
@ankith26 ankith26 deleted the starbuck-SDL-2.32.8 branch July 14, 2025 06:30
Starbuck5 added a commit that referenced this pull request Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants