-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable SSE 4.2 builds (image.tostring) #2227
Comments
Had a look at this and as I understand it, the root issue is that we unconditionally passed I propose that we bump the @illume: Do you remember the version of gcc used or the CentOS version? |
MIght need a bit of https://stackoverflow.com/questions/46165752/does-clang-have-something-like-pragma-gcc-target |
Last time I checked, this does not work with MSVC. As far as I can tell, there is no simple way to do this that works in GCC, clang, and MSVC, and that works for ARM and X86 without additional ifdefs. |
We've dropped support for SDL1 and older manylinux since this issue was started. So now maybe it will work. A couple of years ago it was 97%, now SSE 4.2 is at 98.53% on the steam survey. https://store.steampowered.com/hwsurvey Also, it does seem more things require SSE 4.2 now compared to 2020, so probably we can just enable it by default without much damage. For example dosbox requires it since 2021. I think we can just enable SSE 4.2, and be able to use the nice image.tostring function that @nthykier wrote, and possibly allow @MyreMylar to use SSE 4.2 in blitters. SSE 4.2 could do 4 pixels at once? Similar to #1715 ? https://en.wikipedia.org/wiki/SSE4#SSE4.2
|
Need to figure out how to build this with runtime detection.
Otherwise using SSE2 could be an option.
The text was updated successfully, but these errors were encountered: