-
Notifications
You must be signed in to change notification settings - Fork 185
Implement several missing functions #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! This is great PR. I also appreciate all the minor docfixes. |
Was the blocker the decreased coverage? If so, how do I increase it - what does it measure? |
@potocpav: yes, to some extent. I wanted to add some examples in the docstrings using the :visual-exampe: directive before merging but didn't find enough time to do so. These are executed during tests (so usually bump the coverage) and also included in Sphinx documentation on the readthedocs site. If you include them and all tests pass I will be able to merge it straight away. Sorry for forgetting about this MR. I'm almost always busy :( |
Messed up my repo, accidentally pushed stuff there. Either way, this would need to be updated and integrated with other work to be merged, which I might do in another PR. Closing. |
I needed those 9 functions for my project. I tried my best to implement them in a way similar to the surrounding code.