Skip to content

Conversation

liamhuber
Copy link
Member

Creating from composite classes and instances is now equivalent. Here I also did some renaming, Composite.add/remove/replace to add/remove/replace_node.

Closes #115

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Dec 7, 2023

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/no_owned_creators

Copy link

codacy-production bot commented Dec 7, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.05% (target: -1.00%) 87.50%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3eed68e) 2196 1845 84.02%
Head commit (eea086d) 2158 (-38) 1812 (-33) 83.97% (-0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#121) 16 14 87.50%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@coveralls
Copy link

coveralls commented Dec 7, 2023

Pull Request Test Coverage Report for Build 7133662387

  • 19 of 19 (100.0%) changed or added relevant lines in 4 files are covered.
  • 27 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 89.257%

Files with Coverage Reduction New Missed Lines %
meta.py 1 98.21%
workflow.py 2 85.37%
composite.py 24 87.61%
Totals Coverage Status
Change from base Build 7133243907: -0.05%
Covered Lines: 3830
Relevant Lines: 4291

💛 - Coveralls

@liamhuber liamhuber added the format_black trigger the Black formatting bot label Dec 7, 2023
@liamhuber liamhuber merged commit bb53140 into main Dec 7, 2023
@liamhuber liamhuber deleted the no_owned_creators branch December 7, 2023 20:37
liamhuber pushed a commit that referenced this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black trigger the Black formatting bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplification: node creation works the same from Composite class or instance
3 participants