Skip to content

Conversation

liamhuber
Copy link
Member

This re-parents Channel onto HasLabel (patch) and renames the Channel.node attribute to Channel.owner (minor). As we move to composition mixins (#243), this will help break apart where channels depend on their owner being something that "has IO" and where they really depend on it being a node (basically only necessary for node injection on OutputData).

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/refactor_channel

@liamhuber liamhuber changed the base branch from main to state_mixin March 18, 2024 23:40
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.42% (target: -1.00%) 94.59%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9d7b286) 3151 2734 86.77%
Head commit (d0620f0) 3254 (+103) 2837 (+103) 87.19% (+0.42%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#251) 351 332 94.59%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

1 similar comment
Copy link

codacy-production bot commented Mar 18, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.42% (target: -1.00%) 94.59%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9d7b286) 3151 2734 86.77%
Head commit (d0620f0) 3254 (+103) 2837 (+103) 87.19% (+0.42%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#251) 351 332 94.59%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Base automatically changed from state_mixin to main March 23, 2024 19:15
@liamhuber liamhuber merged commit b29529c into main Mar 23, 2024
@liamhuber liamhuber deleted the refactor_channel branch March 23, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant