-
Notifications
You must be signed in to change notification settings - Fork 3
Allow replacing nodes #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As long as that node has no parent or connections, and can successfully copy the connections of the node it is replacing.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
For readability and to make sure subtests don't depend on state that is modified in other (potentially failing) subtests.
To reflect the fact a class can now be passed
…w_replacing_nodes # Conflicts: # pyiron_workflow/node.py
For Workflows IO is built on-the-fly, so it's a non-issue
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Composite
instances can now replace one of their children with another node instance or class, as long as that node has no parent or connections and has compatible IO (this PR introduces a tool for coping connections from one node to the other)Resolves a couple of the TODOs on #7.