Skip to content

Conversation

liamhuber
Copy link
Member

Switches the self-like argument in macro-defining functions over to self, except for a few cases where we leave it as wf and explicitly tell the story about how you may be working with a worklfow and want to convert it to a macro by copying and pasting.

Also cleaned up some other non-breaking problems with the pedagogical text (english, some variable names, non-impactful code statements, etc.) and tidied up some unused imports.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/canonical_macro

@liamhuber liamhuber mentioned this pull request Apr 11, 2024
11 tasks
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d6ee64c) 3475 3044 87.60%
Head commit (7b29652) 3474 (-1) 3043 (-1) 87.59% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#283) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Base automatically changed from static_io_parent to main April 11, 2024 20:14
@liamhuber liamhuber merged commit 920dd1c into main Apr 11, 2024
@liamhuber liamhuber deleted the canonical_macro branch April 11, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant