[minor] Executorlib ci and docs #388
Conversation
In both comments and class names
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
|
OSX tests started quickly, but timed out to failure |
|
The tests run fine locally, so to start I'll just try rerunning |
|
Nope, still hanging. Unfortunately from the standard log it's not clear what test is doing it, and I can't reproduce it locally. @jan-janssen, thoughts? |
|
Hanging is just CI related and not a true failure |
* Make ProcessPoolExecutor the default executor -- but use executorlib in notebooks * [minor] Don't have a default `Executor` (#390) Make the user choose one specifically.
A follow-up to #386 that purges references to
pympipoolin the docs and executor class name.I also switch to
macos-latestasexecutorlibuses for its CI.This removes
PyMpiPoolExecutoras aCreatorattribute, changing the API, so not a patch; minor.EDIT: After merging in the stack, this also removes the default
Creator.Executor, so we now always specifically ask forProcessPoolExecutororexecutorlib.Executoraccordingly.