-
Notifications
You must be signed in to change notification settings - Fork 3
Draft: add black formatting for tests directory #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm sick and my kid's school hasn't restarted yet, so I'm not going to get to resolving the conflicts yet. Easier will probably be to just cherry pick the top commit and then re-black. Per your comment elsewhere (sorry, lost the ref), if black is going to complain about the multi-line strings, it might be time to just give up on that, despite the fact we both find our version somewhat more readable. The silver lining would be that we could abandon black entirely and just use the ruff formatting... |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Pull Request Test Coverage Report for Build 12640274584Details
💛 - Coveralls |
Ah, sorry @XzzX, I tried to roll back head and merge main so that your commit touching
I'm ready to concede to the formatters on this this one. If I was briefly excited because they were both ok with the following: self.assertLess(
dt,
1.1 * t,
msg="""
Expected the sleeps to run in parallel with minimal overhead (since
it's just a thread pool executor) -- the advantage is that the
constructors should survive (de)serialization
""",
) (Also as |
Thank you, kind of you trying to preserve the history. |
Waiting for
pyiron/actions#138
and
#520