Skip to content

Drop the private type hint #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Drop the private type hint #535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions pyiron_workflow/type_hinting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,9 @@ def valid_value(value, type_hint) -> bool:


def type_hint_to_tuple(type_hint) -> tuple:
if isinstance(
type_hint,
types.UnionType | typing._UnionGenericAlias, # type: ignore
# mypy complains because it thinks typing._UnionGenericAlias doesn't exist
# It definitely does, and we may be able to remove this once mypy catches up
):
if isinstance(type_hint, types.UnionType):
return typing.get_args(type_hint)
else:
return (type_hint,)
return (type_hint,)


def type_hint_is_as_or_more_specific_than(hint, other) -> bool:
Expand Down
Loading