Skip to content

Plotly change size #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 9, 2024
Merged

Plotly change size #132

merged 9 commits into from
Feb 9, 2024

Conversation

samwaseda
Copy link
Member

@samwaseda samwaseda commented Feb 8, 2024 •
edited
Loading

Since the frame is generally super small, I made a larger default size

Update following @liamhuber's comment below.

Before:

Screenshot 2024-02-08 at 19 46 53

After (default height, but can obviously be changed):

Screenshot 2024-02-08 at 19 48 05

liamhuber
liamhuber approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Not a neg just an fyi, this type of UI PR is perfect for snagging before and after screenshots and dragging them into the PR description! 🚀

@samwaseda
Copy link
Member Author

Lgtm. Not a neg just an fyi, this type of UI PR is perfect for snagging before and after screenshots and dragging them into the PR description! 🚀

I updated it!

@liamhuber
Copy link
Member

Lgtm. Not a neg just an fyi, this type of UI PR is perfect for snagging before and after screenshots and dragging them into the PR description! 🚀

I updated it!

Nice! I always trusted you that the change made things better, but now I can agree with you that the change makes things better 😂

Base automatically changed from plotly_draw_frame to main February 8, 2024 21:31
jan-janssen
jan-janssen requested changes Feb 9, 2024
View reviewed changes
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a warning when the height was changed but NGLview or ASE is used for plotting? Just to tell the users that this feature is currently only available for plotly.

jan-janssen
jan-janssen approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jan-janssen
Copy link
Member

As soon as this pull request is merged I create a new release of structuretoolkit.

@samwaseda samwaseda merged commit e6f880b into main Feb 9, 2024
@samwaseda samwaseda deleted the plotly_change_size branch February 9, 2024 07:34
samwaseda added a commit to pyiron/pyiron_atomistics that referenced this pull request Feb 9, 2024
@samwaseda
[minor] Make height available in plot3d
883c4df 
Consistency with [this PR](pyiron/structuretoolkit#132)
@samwaseda samwaseda mentioned this pull request Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-janssen jan-janssen jan-janssen approved these changes

@liamhuber liamhuber liamhuber approved these changes

Assignees

No one assigned

Labels

format_black

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samwaseda @liamhuber @jan-janssen @pyiron-runner