Skip to content

Conversation

samwaseda
Copy link
Member

Following the spontaneous meeting between @pmrv and me, I updated the interstitial class, in the hope that it does what it's supposed to do now.

Main changes:

  • Now the workflow is more easily accessible
  • Classification takes place following the Steinhardt parameters

@samwaseda samwaseda requested a review from pmrv August 1, 2023 16:13
@samwaseda samwaseda added the enhancement New feature or request label Aug 1, 2023
@jan-janssen
Copy link
Member

@samwaseda Can you add tests for this functionality? To me it seems the functionality changed but all the tests pass, so maybe it is not sufficiently tested.

@samwaseda
Copy link
Member Author

It tests the full functionality instead of individual functions, which is the reason why it doesn't fail, but ok I can also add individual tests.

Copy link
Contributor

@pmrv pmrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some docstring nits, especially for cluster_by_steinhardt, because that's non-obvious for other devs. Otherwise lgtm.

Tests are ok imo as they check that known interstitials are found in simple crystals.

@pmrv
Copy link
Contributor

pmrv commented Aug 2, 2023

Ah also I forget: This removes the iterative "refinement" of interstitial positions, in the last session we never used it anymore, but are there cases where it still might? I think you mentioned bcc and that's covered by the tests so might just be remembering it wrong.

samwaseda and others added 3 commits August 8, 2023 13:36
Co-authored-by: Marvin Poul <poul@mpie.de>
Co-authored-by: Marvin Poul <poul@mpie.de>
Co-authored-by: Marvin Poul <poul@mpie.de>
@samwaseda
Copy link
Member Author

Ah also I forget: This removes the iterative "refinement" of interstitial positions, in the last session we never used it anymore, but are there cases where it still might? I think you mentioned bcc and that's covered by the tests so might just be remembering it wrong.

It still does the refinement, but it's not necessary to set it anymore because the algorithm checks the convergence automatically.

@samwaseda samwaseda merged commit 8063ae7 into main Aug 8, 2023
@jan-janssen jan-janssen deleted the interstitials branch August 18, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants