-
Notifications
You must be signed in to change notification settings - Fork 1
Update interstitial class #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@samwaseda Can you add tests for this functionality? To me it seems the functionality changed but all the tests pass, so maybe it is not sufficiently tested. |
It tests the full functionality instead of individual functions, which is the reason why it doesn't fail, but ok I can also add individual tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some docstring nits, especially for cluster_by_steinhardt
, because that's non-obvious for other devs. Otherwise lgtm.
Tests are ok imo as they check that known interstitials are found in simple crystals.
Ah also I forget: This removes the iterative "refinement" of interstitial positions, in the last session we never used it anymore, but are there cases where it still might? I think you mentioned bcc and that's covered by the tests so might just be remembering it wrong. |
Co-authored-by: Marvin Poul <poul@mpie.de>
Co-authored-by: Marvin Poul <poul@mpie.de>
Co-authored-by: Marvin Poul <poul@mpie.de>
It still does the refinement, but it's not necessary to set it anymore because the algorithm checks the convergence automatically. |
Following the spontaneous meeting between @pmrv and me, I updated the interstitial class, in the hope that it does what it's supposed to do now.
Main changes: