Show box cell in plotly #49
Conversation
|
Since there's nothing that breaks will most likely also never break anything, I'm gonna merge it now. Feel free to open another PR for more changes. |
tests/test_visualize.py
Outdated
| self.assertLessEqual( | ||
| np.unique(frame.reshape(-1, 6), axis=0, return_counts=True)[1].max(), | ||
| 1 | ||
| ) | ||
| dx, counts = np.unique( | ||
| np.diff(frame, axis=-2).squeeze().astype(int), axis=0, return_counts=True | ||
| ) | ||
| self.assertEqual(dx.ptp(), 1) | ||
| self.assertEqual(counts.min(), 4) | ||
| self.assertEqual(counts.max(), 4) |
There was a problem hiding this comment.
I don't know what any of these are checking, nor why they should return the integers they do. They don't necessarily need any change, but please specify msg= to clarify.
Ah, I saw it in my inbox and jumped straight to the review without seeing this or even realizing I'd looked at the PR before. I think we're on the same page though, as my review is basically only asking for comments and no code changes, so I agree the code itself is mergeable. (Well, except for the method rename, but we don't need that part) |
Co-authored-by: Liam Huber <liamhuber@greyhavensolutions.com>
|
Comment: Apparently this feature moves the legend slightly. It's probably because plotly creates space for the extra lines in the box. So far it doesn't look like it makes a problem, but someone might want to take a look at it at later point if there's a case arising due to this PR. |
5 participants
I added the box frame in
plot3dfor plotly.