Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compensation of free kick is broken #80

Closed
mihofer opened this issue Aug 1, 2019 · 1 comment
Closed

compensation of free kick is broken #80

mihofer opened this issue Aug 1, 2019 · 1 comment
Assignees
@lmalina @mihofer
Labels
Type: Bug Something isn't working as it should.

Comments

@mihofer
Copy link
Contributor

mihofer commented Aug 1, 2019

when using --is_free_kick = True, harpy breaks when using kicker.phase_correction
issue: dataframe panda does not contain PK2PK column
@mihofer mihofer added the Type: Bug Something isn't working as it should. label Aug 1, 2019
lmalina added a commit that referenced this issue Aug 5, 2019
@lmalina
Fixes #80: Phase correction for amplitude damping after a kick
8fea3c8
lmalina added a commit that referenced this issue Aug 6, 2019
@lmalina
Fixes #80: Squashed commit from bug/80/free_kick_compensation
bc15ca8
@lmalina lmalina mentioned this issue Aug 6, 2019
Merged
lmalina added a commit that referenced this issue Aug 6, 2019
@lmalina
Enhancement/13/optics measurements (#49)
16aaa8b 
Closes #13, follow-ups: #30, #87, #88.

* #73 Add Kicktime to kick_$.tfs (#77)
* harpy/handler.py: added TIME to headers of lin-files
* Refactored kick.py to use only constants as Column names, added time from lin-files
* accelerator.py: refactored strings of element types to AccElementTypes class

* #64 Cleaned .gitignore

* #78 Added plane to RescaleFactor in kick.py

* #83 renamed --accelerator to --tbt_datatype

* #80: Squashed commit from bug/80/free_kick_compensation

* #69 Fixing bug in outliers

* #84 Added debug message for no combinations in N-BPM method
@lmalina
Copy link
Member

lmalina commented Aug 6, 2019

closed by #49

@lmalina lmalina closed this as completed Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmalina lmalina

@mihofer mihofer

Labels
Type: Bug Something isn't working as it should.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmalina @mihofer