Enhancement/13/optics measurements #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optics measurements run with python 3
all imports are absolute and cleaned up
included measurements from 3d kicks:
- normalised dispersion and corresponding dispersion
- dispersion calculated straight from synchrotron oscillation
includes second order dispersion calculation
refactoring and bug fixes in beta from phase:
- fixed which models are used
- fixed the swapped driven and free tunes
- fixed the systematic error calculation (only the systematic errors from left side of probed BPM were taken into account)
- simplified the model management
- joined the ABB, BAB, BBA cases into one
- reduced method signatures (a lot)
made accelerator class and model manager python 3 compatible
also can use config files or dictionaries as the input
- entrypoint was moved to parser/ (sloppy merge) - a few lines in n_bpm_method were mistakenly inside the loop over BPMs
plane dependency is still to be removed from dispersion from 3D kicks and kick calculation
further simplification likely once we decide on driven analysis
additionally combination simplifications in beta_from_phase
…ame (i.e. no files)
compared to python 2 version different cleaning in the two planes is not a problem single plane RDTs are separated and from all good BPMs in the given plane added search for second BPM closest to 90 degree phase advance from the first BPM in a pair this was embedded in phase output (python2), but did not have an equivalent yet needless to say that the module is got vectorised this commit is mostly for the reference since more changes in RDT amplitude fit are foreseen now contains multiple solutions of the same thing
…/13/optics_measurements
…/13/optics_measurements
* harpy/handler.py: added TIME to headers of lin-files * Refactored kick.py to use only constants as Column names, added time from lin-files * accelerator.py: refactored strings of element types to AccElementTypes class
|
Code Climate has analyzed commit 9c6a9ae and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 97.4% (50% is the threshold). This pull request will bring the total coverage in the repository to 70.1% (0.5% change). View more on Code Climate. |
JoschD
added this to Reviewer approved
in Transfer codes from Beta-Beat.src
via automation
This was referenced Aug 6, 2019
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft pull request for optics measurements
There are still some TODOs:
Coupling
Tests: decide on whether to put test files into this repository
Redesign accelerator class