Deprecate nodes import from astroid #2837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdce8p
commented
Sep 29, 2025
|
|
||
| from astroid.util import Uninferable | ||
|
|
||
| __all__ = [ |
There was a problem hiding this comment.
Added __all__ to not expose the _DEPRECATED_* classes here.
cdce8p
force-pushed
the
deprecate-nodes-import
branch
from
df34d94 to
921e924
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2837 +/- ##
=======================================
Coverage 93.36% 93.37%
=======================================
Files 92 92
Lines 11139 11148 +9
=======================================
+ Hits 10400 10409 +9
Misses 739 739
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Pierre-Sassoulas
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #2833
Deprecate the import of node classes from toplevel
astroid.Import them from
astroid.nodesinstead.