fix: add missing http status codes #2840
Merged
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hofrob
force-pushed
the
fix-add-missing-http-status-codes
branch
from
d53d096 to
b1cb9fc
Compare
Pierre-Sassoulas
previously approved these changes
Sep 29, 2025
hofrob
force-pushed
the
fix-add-missing-http-status-codes
branch
from
b1cb9fc to
9cf582a
Compare
hofrob
commented
Sep 29, 2025
Comment on lines
+103
to
+104
| IM_A_TEAPOT = _HTTPStatus(418, 'I\\\'m a Teapot', | ||
| 'Server refuses to brew coffee because it is a teapot.') |
There was a problem hiding this comment.
I'm not sure if you prefer "I'm a Teapot"? Both works.
There was a problem hiding this comment.
You could apply black on the brain content and copy paste the result, that would make for a very clean brain. But honestly it doesn't matter much as long as astroid user get the right value :D
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2840 +/- ##
=======================================
Coverage 93.37% 93.37%
=======================================
Files 92 92
Lines 11148 11148
=======================================
Hits 10409 10409
Misses 739 739
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Pierre-Sassoulas
approved these changes
Sep 29, 2025
Pierre-Sassoulas
temporarily deployed
to
Backport
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
For the sake of completeness, pylint-dev/pylint#8859 is actually about older http status codes which were not part of #2839 or RFC9110 respectively. This PR adds 3 status codes to the HTTP brain:
103 EARLY_HINTS418 IM_A_TEAPOT425 TOO_EARLYcloses pylint-dev/pylint#8859