Skip to content

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 22, 2022

Done using https://pypi.org/project/setuptools-py2cfg plus manual modifications.

After this is reviewed and landed, a migration to pyproject.toml can be achieved using https://pypi.org/project/ini2toml or similar.

cclauss and others added 3 commits September 22, 2022 10:18
Done using https://pypi.org/project/setuptools-py2cfg plus manual modifications.

After this is reviewed and landed, a migration to `pyproject.toml` can be achieved.
@coveralls
Copy link

Coverage Status

Coverage decreased (-86.06%) to 0.0% when pulling 0f241bf on cclauss:patch-1 into 6c1e67e on PyCQA:master.

Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change needed?

@cclauss
Copy link
Contributor Author

cclauss commented Sep 22, 2022

https://setuptools.pypa.io/en/latest/userguide/quickstart.html#basic-use

Setuptools offers first class support for setup.py files as a configuration mechanism.
It is important to remember, however, that running this file as a script (e.g. python setup.py sdist) is strongly discouraged, and that the majority of the command line interfaces are (or will be) deprecated [ ... ]
We also recommend users expose as much as possible configuration in a more declarative way via the pyproject.toml or setup.cfg, and keep the setup.py minimal with only the dynamic parts (or even omit it completely if applicable).

https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html
https://thehackernews.com/2022/09/warning-pypi-feature-executes-code.html

@carlio carlio force-pushed the master branch 5 times, most recently from aa6c7ee to 054b49a Compare May 15, 2023 03:57
@carlio
Copy link
Member

carlio commented May 15, 2023

I have been (manually) moving over to poetry so I will close this as basically done

@carlio carlio closed this May 15, 2023
@cclauss cclauss deleted the patch-1 branch May 15, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants