Burst down the lint package into 5 files #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
This was referenced Apr 26, 2020
PCManticore
reviewed
Apr 27, 2020
| @@ -43,8 +43,6 @@ | |||
| # Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html | |||
There was a problem hiding this comment.
@Pierre-Sassoulas We should keep these two lines in each file since they are not added by https://github.com/PCManticore/copyrite (which is the tool I was using for adding the copyright notices).
There was a problem hiding this comment.
OK, I'm going to fix this, sorry.
Pierre-Sassoulas
added a commit
to Pierre-Sassoulas/pylint
that referenced
this pull request
Apr 27, 2020
Pierre-Sassoulas
added a commit
that referenced
this pull request
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This permits to have smaller files and easier reading of them in the lint packages. The Pylinter class is still huge but this would require too much work to refactor.
Type of Changes