Release branch 2.15.1 #7393
Release branch 2.15.1 #7393
Conversation
Co-authored-by: orSolocate <38433858+orSolocate@users.noreply.github.com>
Pierre-Sassoulas
added
Maintenance
towncrier.toml
Outdated
| version = "2.16.0" | ||
| version = "2.15.1" | ||
| directory = "doc/whatsnew/fragments" | ||
| filename = "doc/whatsnew/2/2.16/index.rst" | ||
| filename = "doc/whatsnew/2/2.15/index.rst" |
There was a problem hiding this comment.
This is going to NOT be a merge conflict and we need to be careful when merging in main.
There was a problem hiding this comment.
I was wondering about this. Do we need to bump to the dev version on main? What's the benefit? Can't we just bump when we need to for a release?
There was a problem hiding this comment.
Well it's useful to know the pylint version we're talking about (2.16.0-dev0 vs 2.15.1). scm_setuptool was nice for this but created a dependencie we did not want...
There was a problem hiding this comment.
Yeah I mean I don't really mind, but referring to main would also work for me.
It reduces the amount of work necessary for a release so I thought it might be something to consider.
There was a problem hiding this comment.
referring to main ?
There was a problem hiding this comment.
As in, I never use 2.16.0-dev0 directly in any of my messages. I often just say main or something like that. There is not much benefit for me to having the bumped version, but that might just be me.
Yes, I was wondering what to do. Maybe use "False positive for 2.15.1" as title ? Maybe remove the titles altogether... ? |
|
We have titles that are duplicated when we generate the patch release note: @DudeNr33 do you have an opinion about the easy way to fix this ? |
Can we fix this by decreasing the title level? I haven't tested this, but can we have duplicate titles if they fall within different top level titles? |
|
I'm currently on vacation and probably won't have time to try around myself until next Monday, sorry! I am a bit surprised that this is an issue, as I would expect others to experience this as well, but I did not find any issue about this in their issue tracker. |
…l is assigned to a class attribute inside the class where the function is defined. (pylint-dev#7395) Closes pylint-dev#6592
Previously pylint would lint a file passed on stdin even if the user meant to ignore the file. This commit fixes that issue. Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
… annotations (pylint-dev#7400) Don't emit 'unused-variable' or 'unused-import' on names in string literal type annotations (pylint-dev#3299) Don't treat strings inside typing.Literal as names
Pierre-Sassoulas
force-pushed
the
release-branch-2.15.1
branch
from
de3fd7f
to
52d26bc
Compare
|
I'm going to fix the release note manually to be able to release until we discuss what we should do. Not sure what to do with #7398, it's in 2.16.0 but it's labelled "need backport", what do you think @DanielNoord ? |
Pierre-Sassoulas
force-pushed
the
release-branch-2.15.1
branch
from
52d26bc
to
3a8e9ee
Compare
|
I thought it would be good to backport as there were other PRs that target that code. If there are regression it would be helpful to have the refactor available on the maintenance branch as well. |
* Fix and refactors for ``docparams`` extension The ``re_only_desc`` regex did not match for white and characters after ``\n``, so some description-only lines weren't getting matched. In addition, lookaheads were added to ``re_param_line`` (i.e. make sure the type group is not followed by a new line (``\n``)). Lastly, named groups (ala Perl regular expressions) were added for slightly improved clarity. Co-authored-by: Hendry, Adam <adam.grant.hendry@gmail.com>
Pierre-Sassoulas
force-pushed
the
release-branch-2.15.1
branch
from
3a8e9ee
to
36f692d
Compare
|
Alright, I moved it to 2.15.1 and cherry-picked it :) I think we can release now |
|
btw, for future reviews I think we should split up the back port and release PRs. Stuff like the broken For now it is fine though! 😄 |
Pierre-Sassoulas
force-pushed
the
release-branch-2.15.1
branch
from
36f692d
to
f94c834
Compare
|
Forgot to regenerate the towncrier file after adding 3 more cherry-pick, my bad. |
| - Fix ignored files being linted when passed on stdin. | ||
|
|
||
| Closes #4354 (`#4354 <https://github.com/PyCQA/pylint/issues/4354>`_) | ||
| - ``missing-return-doc``, ``missing-raises-doc`` and ``missing-yields-doc`` now respect |
There was a problem hiding this comment.
Doesn't towncrier know about white spaces? 😅
There was a problem hiding this comment.
I manually removed the duplicated titles, which is why there might be some problems.
There was a problem hiding this comment.
Let's fix in #7426
No description provided.