Add regression tests. #9071

mbyrnepr2 · 2023-09-25T19:16:34Z

Type of Changes

	Type
	🐛 Bug fix
	✨ New feature
	🔨 Refactoring
	📜 Docs
✓	🧪 Tests

Description

Refs #9069
Refs pylint-dev/astroid#2305

mbyrnepr2 · 2023-09-25T19:32:01Z

Failing CI tests should be fixed when pylint-dev/astroid#2307 is live.

Refs pylint-dev#9069 Refs pylint-dev/astroid#2305

Pierre-Sassoulas · 2023-09-27T07:22:01Z

Willte require astroid 2.15.8 when backporting, this is going to be easier to do manually.

codecov · 2023-09-27T07:26:14Z

Codecov Report

Merging #9071 (8ed99d6) into main (aa29201) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9071   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files         173      173           
  Lines       18664    18664           
=======================================
  Hits        17872    17872           
  Misses        792      792

github-actions · 2023-09-27T07:48:07Z

🤖 Effect of this PR on checked open source code: 🤖

Effect on home-assistant:
The following messages are now emitted:

too-many-ancestors:
Too many ancestors (8/7)
https://github.com/home-assistant/core/blob/70e3da207a7df4394f9bcee25d0d35d715f483f1/homeassistant/components/renault/sensor.py#L86

The following messages are no longer emitted:

too-few-public-methods:
Too few public methods (1/2)
https://github.com/home-assistant/core/blob/70e3da207a7df4394f9bcee25d0d35d715f483f1/homeassistant/components/radarr/sensor.py#L128

Effect on music21:
The following messages are now emitted:

too-many-instance-attributes:
Too many instance attributes (21/20)
https://github.com/cuthbertLab/music21/blob/f457a2ba52ea3f978d805cd52fa101dfb0dd8577/music21/stream/base.py#L104
redefined-variable-type:
Redefinition of keySignatures type from list to music21.stream.iterator.StreamIterator
https://github.com/cuthbertLab/music21/blob/f457a2ba52ea3f978d805cd52fa101dfb0dd8577/music21/stream/base.py#L3265
redefined-variable-type:
Redefinition of ksIter type from list to music21.stream.iterator.StreamIterator
https://github.com/cuthbertLab/music21/blob/f457a2ba52ea3f978d805cd52fa101dfb0dd8577/music21/stream/base.py#L6808

Effect on pytest:
The following messages are no longer emitted:

missing-function-docstring:
Missing function or method docstring
https://github.com/pytest-dev/pytest/blob/b73b4c464c6fa54f55a1c6ed8eaceb5529a161bb/src/_pytest/capture.py#L546

Effect on pandas:
The following messages are now emitted:

no-member:
Method '_selected_obj' has no 'groupby' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/resample.py#L387
no-member:
Method '_obj_with_exclusions' has no 'copy' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/resample.py#L1484
no-member:
Method '_obj_with_exclusions' has no 'copy' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/resample.py#L1728
no-member:
Method '_selected_obj' has no 'copy' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/resample.py#L1802
no-member:
Method '_selected_obj' has no 'reindex' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/resample.py#L1807
too-many-ancestors:
Too many ancestors (9/7)
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/resample.py#L1831
too-many-ancestors:
Too many ancestors (8/7)
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/resample.py#L1843
too-many-ancestors:
Too many ancestors (10/7)
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/resample.py#L1956
too-many-ancestors:
Too many ancestors (8/7)
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/resample.py#L1968
too-many-ancestors:
Too many ancestors (10/7)
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/resample.py#L1992
no-member:
Method '_selected_obj' has no '_mgr' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L162
no-member:
Method '_selected_obj' has no 'dtype' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L163
no-member:
Method '_obj_with_exclusions' has no 'dtype' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L282
redefined-variable-type:
Redefinition of result type from dict to pandas.core.series.Series
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L307
no-member:
Method '_obj_with_exclusions' has no '_constructor' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L323
no-member:
Method '_obj_with_exclusions' has no 'name' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L323
no-member:
Method '_selected_obj' has no '_values' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L526
no-member:
Method '_selected_obj' has no 'dtype' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L530
no-member:
Method '_selected_obj' has no '_constructor' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L532
no-member:
Method '_selected_obj' has no 'name' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L532
no-member:
Method '_obj_with_exclusions' has no 'columns' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L1512
no-member:
Method '_obj_with_exclusions' has no 'T' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L1537
no-member:
Method '_obj_with_exclusions' has no 'axes' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L1564
no-member:
Method '_obj_with_exclusions' has no 'columns' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L1765
no-member:
Method '_obj_with_exclusions' has no 'index' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L1765
no-member:
Method '_obj_with_exclusions' has no 'T' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L2020
no-member:
Method '_obj_with_exclusions' has no '_mgr' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L2022
no-member:
Method '_obj_with_exclusions' has no 'columns' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L2035
no-member:
Method '_obj_with_exclusions' has no 'iloc' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L2038
no-member:
Method '_obj_with_exclusions' has no 'columns' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L2044
no-member:
Method '_selected_obj' has no '_get_axis' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1453
no-member:
Method '_obj_with_exclusions' has no 'ndim' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1657
no-member:
Method '_obj_with_exclusions' has no 'to_frame' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1657
no-member:
Method '_obj_with_exclusions' has no 'ndim' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1676
no-member:
Method '_obj_with_exclusions' has no 'name' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1678
no-member:
Method '_obj_with_exclusions' has no 'columns' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1680
no-member:
Method '_obj_with_exclusions' has no 'ndim' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1693
no-member:
Method '_obj_with_exclusions' has no 'to_frame' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1693
no-member:
Method '_obj_with_exclusions' has no 'index' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1711
no-member:
Method '_obj_with_exclusions' has no 'ndim' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1712
no-member:
Method '_obj_with_exclusions' has no 'name' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1713
no-member:
Method '_obj_with_exclusions' has no 'columns' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1716
no-member:
Method '_obj_with_exclusions' has no '_constructor' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1717
no-member:
Method '_obj_with_exclusions' has no 'ndim' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1729
no-member:
Method '_obj_with_exclusions' has no 'to_frame' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1729
no-member:
Method '_obj_with_exclusions' has no 'ndim' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1745
no-member:
Method '_obj_with_exclusions' has no 'name' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1746
no-member:
Method '_obj_with_exclusions' has no 'columns' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1749
no-member:
Method '_obj_with_exclusions' has no '_constructor' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1750
no-member:
Method '_selected_obj' has no 'shape' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1807
no-member:
Method '_obj_with_exclusions' has no 'shape' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L1807
no-member:
Method '_obj_with_exclusions' has no '_constructor' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L2039
no-member:
Method '_obj_with_exclusions' has no 'index' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L2039
no-member:
Method '_obj_with_exclusions' has no 'name' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L2039
no-member:
Method '_obj_with_exclusions' has no '_get_axis' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L2050
no-member:
Method '_selected_obj' has no 'take' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L2063
no-member:
Method '_selected_obj' has no 'index' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L2065
no-member:
Method '_selected_obj' has no 'shape' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L2069
no-member:
Method '_selected_obj' has no 'where' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L2070
no-member:
Method '_obj_with_exclusions' has no 'columns' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L2756
no-member:
Method '_obj_with_exclusions' has no 'iloc' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L2776
no-member:
Method '_obj_with_exclusions' has no 'columns' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L2777
no-member:
Method '_selected_obj' has no 'dtype' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L3493
no-member:
Method '_selected_obj' has no '_values' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L3498
no-member:
Method '_obj_with_exclusions' has no 'describe' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L3520
no-member:
Method '_obj_with_exclusions' has no 'ndim' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L3523
no-member:
Method '_selected_obj' has no 'dropna' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L4244
no-member:
Method '_obj_with_exclusions' has no '_get_axis' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L4564
no-member:
Method '_obj_with_exclusions' has no '_get_axis' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L4638
no-member:
Method '_selected_obj' has no '_get_numeric_data' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L4940
no-member:
Method '_selected_obj' has no '_get_numeric_data' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L5015
no-member:
Method '_obj_with_exclusions' has no '_reindex_with_indexers' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L5159
no-member:
Method '_obj_with_exclusions' has no 'axes' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L5160
no-member:
Method '_obj_with_exclusions' has no 'ndim' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L5269
no-member:
Method '_obj_with_exclusions' has no 'dtype' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L5270
no-member:
Method '_obj_with_exclusions' has no 'dtypes' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L5273
no-member:
Method '_selected_obj' has no 'iloc' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L5494
no-member:
Method '_selected_obj' has no 'empty' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L5688
no-member:
Method '_selected_obj' has no 'take' member
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/groupby.py#L5721
redefined-variable-type:
Redefinition of df type from pandas.core.frame.DataFrame to pandas.core.groupby.generic.DataFrameGroupBy
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/tests/frame/test_reductions.py#L1116
redefined-variable-type:
Redefinition of grouped type from pandas.core.groupby.generic.SeriesGroupBy to pandas.core.groupby.generic.DataFrameGroupBy
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/tests/groupby/test_filters.py#L78
redefined-variable-type:
Redefinition of grouped type from pandas.core.groupby.generic.SeriesGroupBy to pandas.core.groupby.generic.DataFrameGroupBy
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/tests/groupby/test_filters.py#L90
redefined-variable-type:
Redefinition of grouped type from pandas.core.groupby.generic.SeriesGroupBy to pandas.core.groupby.generic.DataFrameGroupBy
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/tests/groupby/test_filters.py#L228

The following messages are no longer emitted:

super-init-not-called:
init method from base class 'PandasObject' is not called
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/resample.py#L1601
too-many-ancestors:
Too many ancestors (8/7)
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/resample.py#L1831
too-many-ancestors:
Too many ancestors (9/7)
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/resample.py#L1956
too-many-ancestors:
Too many ancestors (9/7)
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/resample.py#L1992
missing-function-docstring:
Missing function or method docstring
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L227
missing-function-docstring:
Missing function or method docstring
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L231
unused-argument:
Unused argument 'numeric_only'
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L518
missing-function-docstring:
Missing function or method docstring
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L724
missing-function-docstring:
Missing function or method docstring
https://github.com/pandas-dev/pandas/blob/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/groupby/generic.py#L1434

Effect on sentry:
The following messages are now emitted:

arguments-renamed:
Parameter 'instance_id' has been renamed to 'user' in overriding 'UserOptionManager._make_key' method
https://github.com/getsentry/sentry/blob/0706460dd4f27edfef7429ba76f4357bc94b6db6/src/sentry/models/options/user_option.py#L24
assignment-from-none:
Assigning result of a function call, where the function returns None
https://github.com/getsentry/sentry/blob/0706460dd4f27edfef7429ba76f4357bc94b6db6/src/sentry/plugins/helpers.py#L25
assignment-from-none:
Assigning result of a function call, where the function returns None
https://github.com/getsentry/sentry/blob/0706460dd4f27edfef7429ba76f4357bc94b6db6/src/sentry/plugins/helpers.py#L53
assignment-from-no-return:
Assigning result of a function call, where the function has no return
https://github.com/getsentry/sentry/blob/0706460dd4f27edfef7429ba76f4357bc94b6db6/src/sentry/plugins/helpers.py#L55

The following messages are no longer emitted:

missing-function-docstring:
Missing function or method docstring
https://github.com/getsentry/sentry/blob/0706460dd4f27edfef7429ba76f4357bc94b6db6/src/sentry/models/options/organization_option.py#L83
unused-argument:
Unused argument 'kwargs'
https://github.com/getsentry/sentry/blob/0706460dd4f27edfef7429ba76f4357bc94b6db6/src/sentry/models/options/organization_option.py#L83
missing-function-docstring:
Missing function or method docstring
https://github.com/getsentry/sentry/blob/0706460dd4f27edfef7429ba76f4357bc94b6db6/src/sentry/models/options/organization_option.py#L86
unused-argument:
Unused argument 'kwargs'
https://github.com/getsentry/sentry/blob/0706460dd4f27edfef7429ba76f4357bc94b6db6/src/sentry/models/options/organization_option.py#L86
missing-function-docstring:
Missing function or method docstring
https://github.com/getsentry/sentry/blob/0706460dd4f27edfef7429ba76f4357bc94b6db6/src/sentry/models/options/project_option.py#L134
unused-argument:
Unused argument 'kwargs'
https://github.com/getsentry/sentry/blob/0706460dd4f27edfef7429ba76f4357bc94b6db6/src/sentry/models/options/project_option.py#L134
missing-function-docstring:
Missing function or method docstring
https://github.com/getsentry/sentry/blob/0706460dd4f27edfef7429ba76f4357bc94b6db6/src/sentry/models/options/project_option.py#L137
unused-argument:
Unused argument 'kwargs'
https://github.com/getsentry/sentry/blob/0706460dd4f27edfef7429ba76f4357bc94b6db6/src/sentry/models/options/project_option.py#L137
missing-function-docstring:
Missing function or method docstring
https://github.com/getsentry/sentry/blob/0706460dd4f27edfef7429ba76f4357bc94b6db6/src/sentry/models/options/user_option.py#L128
unused-argument:
Unused argument 'kwargs'
https://github.com/getsentry/sentry/blob/0706460dd4f27edfef7429ba76f4357bc94b6db6/src/sentry/models/options/user_option.py#L128
missing-function-docstring:
Missing function or method docstring
https://github.com/getsentry/sentry/blob/0706460dd4f27edfef7429ba76f4357bc94b6db6/src/sentry/models/options/user_option.py#L133
unused-argument:
Unused argument 'kwargs'
https://github.com/getsentry/sentry/blob/0706460dd4f27edfef7429ba76f4357bc94b6db6/src/sentry/models/options/user_option.py#L133
too-few-public-methods:
Too few public methods (0/2)
https://github.com/getsentry/sentry/blob/0706460dd4f27edfef7429ba76f4357bc94b6db6/src/sentry/replays/lib/new_query/fields.py#L123

Effect on psycopg:
The following messages are now emitted:

not-async-context-manager:
Async context manager 'NoneType' doesn't implement aenter and aexit.
https://github.com/psycopg/psycopg/blob/c6dae8dbd69ac791075d4d30aea4a1041646a187/psycopg/psycopg/connection_async.py#L426
not-context-manager:
Context manager 'NoneType' doesn't implement enter and exit.
https://github.com/psycopg/psycopg/blob/c6dae8dbd69ac791075d4d30aea4a1041646a187/psycopg/psycopg/connection.py#L1036

The following messages are no longer emitted:

missing-function-docstring:
Missing function or method docstring
https://github.com/psycopg/psycopg/blob/c6dae8dbd69ac791075d4d30aea4a1041646a187/psycopg/psycopg/crdb/connection.py#L145

This comment was generated for commit 8ed99d6

Pierre-Sassoulas

Primer is non trivial to review, need to understand if it's change in the primed repo or due to astroid upgrade.

jacobtylerwalls · 2023-09-28T00:35:30Z

Primer is non trivial to review, need to understand if it's change in the primed repo or due to astroid upgrade.

Mixture of astroid upgrade and 🤷‍♂️. The homeassistant/music21/pandas changes are same as in #9065. The others aren't. I have faith that we're making things less flaky overall, but I wouldn't say we've defeated flakiness (pylint-dev/astroid#2273 is outstanding).

jacobtylerwalls · 2023-09-28T01:19:50Z

or due to astroid upgrade.

Oh, did you mean just this branch's upgrade from 3.0 beta to 3.0 final? I don't think there was anything substantive there for these primer results. If you search the closed PRs for some of the variable names mentioned in these primer messages like "ksIter" from music21 you'll see that they're frequent flyers ✈️ . EDIT: aha, there was! See #9071 (comment).

Pierre-Sassoulas

Thank you for the insight @jacobtylerwalls. I think the fix to #8998 will help us to make this review easier in the future by separating bleeding edge and upgrade.

I'm worried about pandas in particular (lots of new no-members FP). They do not seems to be due to changes on the bleeding edge repo we use (https://github.com/pandas-dev/pandas/blame/61d2056e4251b8d1c387f2577f0407062b9ab903/pandas/core/resample.py#L387 was modified 7 months ago and just appeared). I don't see anything obvious that we changed between the last alpha of astroid and now that could be the cause though.

jacobtylerwalls · 2023-09-30T13:46:28Z

I don't see anything obvious that we changed between the last alpha of astroid and now that could be the cause though.

Actually this is due to the change from 3.0b to 3.0 final. You can reproduce with:

python3.11 -m pylint tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py --disable=all --enable=no-member

Before pylint-dev/astroid@89dfb485:

************* Module pandas.core.resample
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:387:15: E1101: Method '_selected_obj' has no 'groupby' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1484:18: E1101: Method '_obj_with_exclusions' has no 'copy' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1520:15: E1101: Method '_selected_obj' has no 'ndim' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1521:23: E1101: Method '_selected_obj' has no 'name' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1531:15: E1101: Method '_selected_obj' has no 'ndim' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1533:64: E1101: Method '_selected_obj' has no 'name' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1641:16: E1101: Instance of '_GroupByMixin' has no '_resampler_cls' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1649:15: E1101: Instance of '_GroupByMixin' has no '_wrap_result' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1728:18: E1101: Method '_obj_with_exclusions' has no 'copy' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1802:21: E1101: Method '_selected_obj' has no 'copy' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1807:21: E1101: Method '_selected_obj' has no 'reindex' member (no-member)

------------------------------------------------------------------
Your code has been rated at 9.24/10 (previous run: 9.45/10, -0.21)

Then pylint-dev/astroid@89dfb485 (astroid 3.0 beta) removes 3 messages:

************* Module pandas.core.resample
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1484:18: E1101: Method '_obj_with_exclusions' has no 'copy' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1521:23: E1101: Method '_selected_obj' has no 'name' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1533:64: E1101: Method '_selected_obj' has no 'name' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1641:16: E1101: Instance of '_GroupByMixin' has no '_resampler_cls' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1649:15: E1101: Instance of '_GroupByMixin' has no '_wrap_result' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1728:18: E1101: Method '_obj_with_exclusions' has no 'copy' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1802:21: E1101: Method '_selected_obj' has no 'copy' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1807:21: E1101: Method '_selected_obj' has no 'reindex' member (no-member)

------------------------------------------------------------------
Your code has been rated at 9.45/10 (previous run: 9.24/10, +0.21)

Then astroid 3.0 final reverts, giving the original 11 messages again:

************* Module pandas.core.resample
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:387:15: E1101: Method '_selected_obj' has no 'groupby' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1484:18: E1101: Method '_obj_with_exclusions' has no 'copy' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1520:15: E1101: Method '_selected_obj' has no 'ndim' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1521:23: E1101: Method '_selected_obj' has no 'name' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1531:15: E1101: Method '_selected_obj' has no 'ndim' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1533:64: E1101: Method '_selected_obj' has no 'name' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1641:16: E1101: Instance of '_GroupByMixin' has no '_resampler_cls' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1649:15: E1101: Instance of '_GroupByMixin' has no '_wrap_result' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1728:18: E1101: Method '_obj_with_exclusions' has no 'copy' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1802:21: E1101: Method '_selected_obj' has no 'copy' member (no-member)
tests/.pylint_primer_tests/pandas-dev/pandas/pandas/core/resample.py:1807:21: E1101: Method '_selected_obj' has no 'reindex' member (no-member)

The reason the messages went away in pylint-dev/astroid@89dfb485 is because inference got worse, and no-member gets shy when things are uninferable:

3.0 beta:

(Pdb) node.expr
<Attribute._selected_obj l.1520 at 0x106b61d90>
(Pdb) node.expr.inferred()
[Uninferable]

versus 3.0 final

(Pdb) node.expr
<Attribute._selected_obj l.1520 at 0x107619e10>
(Pdb) node.expr.inferred()
[<BoundMethod _selected_obj of pandas.core.groupby.groupby.BaseGroupBy at 0x4817398224]

So I think we're good here.

jacobtylerwalls · 2023-09-30T14:10:33Z

I guess going forward we should be careful about backporting things that involve inference changes.

Pierre-Sassoulas · 2023-09-30T21:21:06Z

It also seems no-member is not favoring false negatives when the inference fail. I don't think this is what we usually do. Not sure if it can be inverted at this point, primer would need to be very carefully checked if we do that (could be a strong point of pylint for users ?).

mbyrnepr2 added Skip news 🔇 This change does not require a changelog entry tests labels Sep 25, 2023

Pierre-Sassoulas added this to the 2.17.7 milestone Sep 25, 2023

mbyrnepr2 mentioned this pull request Sep 25, 2023

False positive unsubscriptable-object pylint-dev/astroid#2307

Merged

mbyrnepr2 marked this pull request as ready for review September 25, 2023 19:56

mbyrnepr2 force-pushed the regression_tests_no_member_and_unsubscriptable_object branch from e01b501 to b2afb38 Compare September 26, 2023 20:03

mbyrnepr2 and others added 2 commits September 27, 2023 09:17

Add regression tests.

2f213dc

Refs pylint-dev#9069 Refs pylint-dev/astroid#2305

Upgrade astroid to 3.0.0

8ed99d6

Pierre-Sassoulas force-pushed the regression_tests_no_member_and_unsubscriptable_object branch from fc99872 to 8ed99d6 Compare September 27, 2023 07:17

Pierre-Sassoulas added the Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer label Sep 27, 2023

Pierre-Sassoulas approved these changes Sep 27, 2023

View reviewed changes

Pierre-Sassoulas requested changes Sep 27, 2023

View reviewed changes

Pierre-Sassoulas reviewed Sep 28, 2023

View reviewed changes

jacobtylerwalls merged commit 881e6bc into pylint-dev:main Sep 30, 2023
46 checks passed

jacobtylerwalls mentioned this pull request Sep 30, 2023

Upgrade astroid to 2.15.8 on 2.17.x branch #9081

Merged

Pierre-Sassoulas removed the Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer label Sep 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add regression tests. #9071

Add regression tests. #9071

mbyrnepr2 commented Sep 25, 2023

mbyrnepr2 commented Sep 25, 2023

Pierre-Sassoulas commented Sep 27, 2023

codecov bot commented Sep 27, 2023

github-actions bot commented Sep 27, 2023

Pierre-Sassoulas left a comment

jacobtylerwalls commented Sep 28, 2023

jacobtylerwalls commented Sep 28, 2023 •

edited

Loading

Pierre-Sassoulas left a comment

jacobtylerwalls commented Sep 30, 2023

jacobtylerwalls commented Sep 30, 2023

Pierre-Sassoulas commented Sep 30, 2023

Add regression tests. #9071

Add regression tests. #9071

Conversation

mbyrnepr2 commented Sep 25, 2023

Type of Changes

Description

mbyrnepr2 commented Sep 25, 2023

Pierre-Sassoulas commented Sep 27, 2023

codecov bot commented Sep 27, 2023

Codecov Report

github-actions bot commented Sep 27, 2023

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

jacobtylerwalls commented Sep 28, 2023

jacobtylerwalls commented Sep 28, 2023 • edited Loading

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

jacobtylerwalls commented Sep 30, 2023

jacobtylerwalls commented Sep 30, 2023

Pierre-Sassoulas commented Sep 30, 2023

jacobtylerwalls commented Sep 28, 2023 •

edited

Loading