Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default values of INS_NUM and TEST_NUM lead to overfitting #2

Closed
mjuarezm opened this issue Aug 10, 2016 · 1 comment
Closed

The default values of INS_NUM and TEST_NUM lead to overfitting #2

mjuarezm opened this issue Aug 10, 2016 · 1 comment

Comments

@mjuarezm
Copy link
Contributor

There is a mismatch between go-knn and Wang-kNN on how the number of instances for train/testing is initialized. Tao sets INST_NUM=60 and TEST_NUM=30 (lines 16 and 17 of flearner.cpp in https://crysp.uwaterloo.ca/software/webfingerprint/knn.zip). It seems go-knn is a port of a different version of flearner.cpp found in https://crysp.uwaterloo.ca/software/webfingerprint/attacks.zip.

The problem is that the INST_NUM is interpreted as the total number of instances per class in go-knn, while in Wang-kNN it's defined as the number of training instances for each class. The result is that the same set of instances is used for training and testing.

pylls added a commit that referenced this issue Aug 11, 2016
@mjuarezm
Copy link
Contributor Author

Fixed in #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant