Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #2 #3

Merged
merged 3 commits into from
Aug 11, 2016
Merged

Fixes issue #2 #3

merged 3 commits into from
Aug 11, 2016

Conversation

mjuarezm
Copy link
Contributor

@mjuarezm mjuarezm commented Aug 10, 2016

There shouldn't be an overlap between the test and training sets. This fix declares a new constant TrainNum which corresponds to the number of instances for each class used for training. InstNum has the meaning of total number of instances for each class. We also need to modify the functions to parse the files so to select different ranges of instances for training and testing.

As expected, we obtain slightly lower accuracy scores:

2016/08/10 20:44:15 starting to learn distance...
distance... 5999 (0-6000)
2016/08/10 20:45:45 finished
2016/08/10 20:45:45 started computing accuracy...
accuracy... 11999 (0-12000)
2016/08/10 20:52:29 finished
2016/08/10 20:52:29 Accuracy: 0.806667 0.993667

pylls and others added 3 commits August 11, 2016 12:51
split into train and testing sets by default.
@pylls pylls merged commit bdff96d into pylls:master Aug 11, 2016
@pylls
Copy link
Owner

pylls commented Aug 11, 2016

Thanks a bunch 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants