Skip to content

Conversation

aseyboldt
Copy link
Member

No description provided.

@aseyboldt aseyboldt requested a review from Copilot May 27, 2025 15:28
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces a shortcut for cases where the posterior is empty (i.e. when math.dim() equals 0) to avoid unnecessary iterations and prepares the next release version. Key changes include:

  • Adding an early return in src/nuts.rs when math.dim() is 0.
  • Updating dependency features in Cargo.toml.
  • Updating the CHANGELOG.md to document the version bump and feature changes.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/nuts.rs Added a conditional early return to handle empty posteriors.
Cargo.toml Updated version and removed unused features from faer.
CHANGELOG.md Documented the version bump and related changes.


let mut tree = NutsTree::new(init.clone());

if math.dim() == 0 {
Copy link
Preview

Copilot AI May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a comment to explain why an early return is appropriate when math.dim() is 0. This will improve maintainability and clarity for future developers.

Copilot uses AI. Check for mistakes.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.67%. Comparing base (394c629) to head (ec9205f).
Report is 60 commits behind head on main.

Files with missing lines Patch % Lines
src/nuts.rs 50.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (394c629) and HEAD (ec9205f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (394c629) HEAD (ec9205f)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #35       +/-   ##
===========================================
- Coverage   83.77%   71.67%   -12.11%     
===========================================
  Files           8       18       +10     
  Lines        1923     4836     +2913     
===========================================
+ Hits         1611     3466     +1855     
- Misses        312     1370     +1058     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aseyboldt aseyboldt merged commit bbfc69a into pymc-devs:main May 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants