improvements to glm.ipynb

[mjhajharia]

glm.ipynb is not broken anymore after #177, a few minor updates in documentation or markdown cells are still left, doing them in this PR as i get time, nothing urgent, but everyone feel free to make suggestions!!!!

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[mjhajharia]

@OriolAbril I've taken care of all the comments, copying this comment from the previous PR over here so it stays in my head.

_

The explanation is great and the link to the family object too. I also have a myst related extra note here (again, so not implement yet) that we could use intersphinx for that link so that if bambi decides to rename master to main, we'll only have to change a link in conf.py and regenerate docs for everything to work again, otherwise we'll have to track down all links and update them. Same thing if documentation is reorganized, files renamed or moved to a different folder structure

_

[MarcoGorelli]

looks good to me

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

OriolAbril commented on 2021-06-18T11:54:05Z
----------------------------------------------------------------

Here is where I think we should add a sentence on what the common key passed to priors means. Maybe

The "common" key in the priors dict defines the prior for all common effects at the same time. As explained in a section below, Bambi supports two types of effects, common and group effects.

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

OriolAbril commented on 2021-06-18T11:54:06Z
----------------------------------------------------------------

I would leave the explanation text as it was originally and only remove the link to the source code. I find the extra explanation inside the parenthesis a bit confusing here, because here we are talking about common and group as types of effects, not as keys of the priors argument.

[fonnesbeck]

@almostmeenal just address Oriol's comment and this is good to merge.

[mjhajharia]

thanks a ton for the help @OriolAbril !!!!

[mjhajharia]

@fonnesbeck this is done, i'm sorry for the delay :((