Refactor fix thumbnails. #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite thumbnails to separate directory.
twiecki
changed the title
|
OK, thumbnails are showing up now on the build docs. |
OriolAbril
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
skimmed the changes and they look good, the only comment is I think we should add the thumbnail directory to the gitignore.
I won't be able to join today, and the navbar PR will need to be rebased after this I think. It would be great if someone can take that over and merge it so the website already looks the same for all sites.
|
Thanks @OriolAbril. I'll work on the navbar PRs next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename gallery_generator to thumbnail_extractor. Add debug output. Write thumbnails to separate directory.
Fixes #346.