Make xhistogram dependency optional #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
remove_histogram_dep
branch
from
7c5944e to
f03e0bd
Compare
|
let's add to a setup.py an extention extras=dict(histogram=[...], complete=[...])So one can install a specific set of dependencies |
Do you want to push that into this PR? I have no idea how that's done but sounds quite good |
ricardoV94
commented
Nov 16, 2022
Co-authored-by: Ricardo Vieira <28983449+ricardoV94@users.noreply.github.com>
|
looks good to me |
ferrine
previously approved these changes
Nov 17, 2022
|
Thanks @ferrine! |
|
I noticed dask requirement on its own does not make sense so I've incremented the dependency list |
|
ricardoV94
commented
Nov 18, 2022
Co-authored-by: Ricardo Vieira <28983449+ricardoV94@users.noreply.github.com>
…o remove_histogram_dep
ferrine
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82