Skip to content

Rethinking_2 Chp_03: add seed, fix typo #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2021

Conversation

joannadiong
Copy link
Contributor

I added a seed to the Chp 3 notebook as per the PyMC Notebook style, and updated the ax.imshow() origin keyword to lower. Notebook has been re-compiled.

Another small PR. Cheers.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks! Looks good, though

updated the ax.imshow() origin keyword to lower

, where is this change? I can't see it

@joannadiong joannadiong deleted the fix/update-style branch December 21, 2020 09:34
@AlexAndorra
Copy link
Contributor

Any reason this was closed? I don't see any problem with it

@aloctavodia
Copy link
Member

I think @joannadiong accidentally included in this PR a change already merged in a previous PR. @joannadiong let us know if you need help with git/github. We know it can be very tricky!

@joannadiong
Copy link
Contributor Author

Hi @MarcoGorelli, I appear to have mistaken a Chp 4 change for Chp 3. So Chp 3 changes are only the seed and a typo. I will update the Issue title for clarity but leave intact the orignal comment message.

To @AlexAndorra and @aloctavodia, not sure, but I may have accidentally closed the Issue when the branch I was working on was deleted. Apologies. In future, should branches be deleted only after Issues are closed by a maintainer?

Yes please, Git/GitHub refs especially for contributor standard practice would be great. Thank you.

@joannadiong joannadiong changed the title Rethinking_2 Chp_03: add seed, update keyword Rethinking_2 Chp_03: add seed, fix typo Dec 21, 2020
@joannadiong joannadiong restored the fix/update-style branch December 21, 2020 21:48
@joannadiong joannadiong reopened this Dec 21, 2020
@MarcoGorelli
Copy link
Contributor

MarcoGorelli commented Dec 22, 2020

Cool, thanks for explaining - I think this is fine then

Re-git: I think the first 3 chapters of this book do a really good job of teaching you the fundamentals


And yes, you probably will only want to delete a branch after it's been merged (unless you decide you no longer want the pull request to be considered!)

@joannadiong
Copy link
Contributor Author

Thanks @MarcoGorelli for the ref -- it's a good book.

Happy for you to merge the small edits and close the PR. Then I will delete the branch. Cheers

Copy link
Contributor

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcoGorelli MarcoGorelli merged commit fc97ac2 into pymc-devs:master Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants