Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed interactive_sampling #1423

Merged
merged 1 commit into from
Oct 3, 2016
Merged

Removed interactive_sampling #1423

merged 1 commit into from
Oct 3, 2016

Conversation

fonnesbeck
Copy link
Member

nbsample has no test coverage and has not been maintained. This PR removes it, though we welcome future attempts to implement something like it.

Closes #1417

@coveralls
Copy link

coveralls commented Oct 3, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.6%) to 84.394% when pulling e0858f7 on remove_nbsample into bd32ce2 on master.

@twiecki
Copy link
Member

twiecki commented Oct 3, 2016

With the new progress bar we could also achieve the same thing much simpler.

@twiecki twiecki merged commit 02ef44f into master Oct 3, 2016
@twiecki twiecki deleted the remove_nbsample branch October 3, 2016 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fonnesbeck @coveralls @twiecki