Minor improvements to 3 notebooks #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are kinda hard to review due to the NB if the changes are only small. Feel free to merge if you think they are innocuous enough. |
|
They are pretty minor improvements. I will merge them, but feel free to raise an issue if anyone notices something amiss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've cleaned up the language in a couple of notebooks, and tweaked the code in the divergence detection notebook. The output in a few places did not correspond to the text (for example, there was no bias--amazingly--in the very first run of the model). I also added random number seeds to make it more reliable.