Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Pytensor dependency to >=2.18.1,<2.19 #7020

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Nov 21, 2023

@ricardoV94 ricardoV94 added no releasenotes Skipped in automatic release notes generation major Include in major changes release notes section labels Nov 21, 2023
@ricardoV94 ricardoV94 changed the title Bump Pytensor dependency to >=2.18,<2.19 Bump Pytensor dependency to 2.18,<2.19 Nov 21, 2023
@ricardoV94 ricardoV94 added pytensor release and removed no releasenotes Skipped in automatic release notes generation labels Nov 21, 2023
@twiecki
Copy link
Member

twiecki commented Nov 21, 2023

Do we not support Python 3.12 with that? E.g. https://github.com/pymc-devs/pymc/blob/main/setup.py#L35

@ricardoV94
Copy link
Member Author

No, that is still an open PR: pymc-devs/pytensor#488

@ricardoV94
Copy link
Member Author

Given the flags issues in pymc-devs/pytensor#508 and pymc-devs/pytensor#515 and it's probably better to wait and pin a version once that's fixed

@ricardoV94 ricardoV94 marked this pull request as draft November 23, 2023 08:10
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #7020 (c29e36e) into main (0b85d02) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7020   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files         101      101           
  Lines       16827    16827           
=======================================
  Hits        15509    15509           
  Misses       1318     1318           

@ricardoV94 ricardoV94 changed the title Bump Pytensor dependency to 2.18,<2.19 Bump Pytensor dependency to >=2.18.1,<2.19 Nov 24, 2023
@ricardoV94 ricardoV94 marked this pull request as ready for review November 25, 2023 07:43
@ricardoV94 ricardoV94 merged commit f8b142a into pymc-devs:main Nov 25, 2023
22 checks passed
@ricardoV94 ricardoV94 deleted the update_pytensor_dep branch November 25, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Include in major changes release notes section pytensor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants