Improve HSGP and ZeroInflated / Hurdle distributions docs #7189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7189 +/- ##
==========================================
- Coverage 92.26% 91.84% -0.43%
==========================================
Files 100 100
Lines 16880 16880
==========================================
- Hits 15574 15503 -71
- Misses 1306 1377 +71
|
|
Failing test seems completely unrelated. Should I just rerun it? |
juanitorduz
reviewed
Mar 11, 2024
Comment on lines
+307
to
+310
| # The centered approximation can be more efficient when | ||
| # the GP is stronger than the noise | ||
| # beta = pm.Normal("beta", sigma=sqrt_psd, size=gp._m_star) | ||
| # f = pm.Deterministic("f", phi @ beta) |
There was a problem hiding this comment.
Out of curiosity: is this something empirical, or is there a general statement about it? :)
|
Empirical on my side, but I know Bill also told me that.
I'm guessing this is similar to the fact that the centered Normal
parametrization works better in a hierarchical model for groups which have
a lot of data
El El lun, 11 mar 2024 a la(s) 17:09, Juan Orduz ***@***.***>
escribió:
… ***@***.**** commented on this pull request.
------------------------------
In pymc/gp/hsgp_approx.py
<#7189 (comment)>:
> + # The centered approximation can be more efficient when
+ # the GP is stronger than the noise
+ # beta = pm.Normal("beta", sigma=sqrt_psd, size=gp._m_star)
+ # f = pm.Deterministic("f", phi @ beta)
Out of curiosity: is this something empirical, or is there a general
statement about it? :)
—
Reply to this email directly, view it on GitHub
<#7189 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHIJMTD5QI4GU7JWS4D4X7TYXYFNZAVCNFSM6AAAAABEPONYL6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRZGEYDEOJTGY>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
ricardoV94
approved these changes
Mar 13, 2024
|
@AlexAndorra small nitpick, would have been better to have two separate commits for the two unrelated changes (Mixture, HSGP) |
|
True. Noted for next time @ricardoV94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just a small PR to improve and fix some typos in the doc pages of:
prior_linearizedmethod)ZeroInflateddistributions (switched from "variates" to "draws", which is more common and much clearer when teaching)Hurdledistributions (same change as previous point)Ready for review and merge
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7189.org.readthedocs.build/en/7189/