Reverse order of tau and sd in Normal-related likelihoods #1398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiecki
changed the title
|
Coverage increased (+0.05%) to 81.27% when pulling 7d50d78966307601a17eb1dc4eec5d132b5ae591 on reverse_tau_sd into e9ee56a on master. |
… add cov to multivariate normal.
…al arguments before. DOC Add new calling signatures to release notes.
twiecki
force-pushed
the
reverse_tau_sd
branch
from
b4aa10a to
3d1a702
Compare
springcoil
approved these changes
Sep 27, 2016
Closed
This was referenced Sep 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argument order of tau and sd was switched for distributions of the normal family:
Normal()Lognormal()HalfNormal()Old:
Normal(name, mu, tau)New:
Normal(name, mu, sd)(supplying keyword arguments is unaffected).MvNormalcalling signature also changed:Old:
MvNormal(name, mu, tau)New:
MvNormal(name, mu, cov)(supplying keyword arguments is unaffected).Addresses #1385.