Skip to content

Conversation

AustinRochford
Copy link
Member

@twiecki
Copy link
Member

twiecki commented Sep 27, 2016

Fantastic, thanks @AustinRochford. I realized one thing, in #1398 we allow to pass cov directly to MvNormal which would make this example even more concise. Anyway, will have to merge that first.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.219% when pulling a37ea75 on AustinRochford:docs-add-lkj-example into e9ee56a on pymc-devs:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.219% when pulling a37ea75 on AustinRochford:docs-add-lkj-example into e9ee56a on pymc-devs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.219% when pulling a37ea75 on AustinRochford:docs-add-lkj-example into e9ee56a on pymc-devs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.219% when pulling a37ea75 on AustinRochford:docs-add-lkj-example into e9ee56a on pymc-devs:master.

@coveralls
Copy link

coveralls commented Sep 27, 2016

Coverage Status

Coverage remained the same at 81.219% when pulling a37ea75 on AustinRochford:docs-add-lkj-example into e9ee56a on pymc-devs:master.

Copy link
Contributor

@springcoil springcoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps change this example based on the cov/ tau changes that Thomas Wiecki mentioned.

@coveralls
Copy link

coveralls commented Sep 28, 2016

Coverage Status

Coverage increased (+0.02%) to 81.234% when pulling 43c0d7b on AustinRochford:docs-add-lkj-example into e9ee56a on pymc-devs:master.

@twiecki
Copy link
Member

twiecki commented Sep 28, 2016

Can you fix the headings? Title should be # Title, subtitles ## subtitle etc. Also, feel free to add your author name and a link to your blog / twitter to the top if you want.

Typo: visuall -> visually

@twiecki
Copy link
Member

twiecki commented Sep 28, 2016

Also theano.tensor should be imported as tt, not T.

@AustinRochford
Copy link
Member Author

@twiecki @springcoil I think that should do it for the comments above. Let me know if you have any others.

@twiecki twiecki merged commit a827504 into pymc-devs:master Sep 28, 2016
@twiecki
Copy link
Member

twiecki commented Sep 28, 2016

👍

@twiecki
Copy link
Member

twiecki commented Sep 28, 2016

@coveralls
Copy link

coveralls commented Sep 28, 2016

Coverage Status

Coverage increased (+2.9%) to 84.127% when pulling 1697779 on AustinRochford:docs-add-lkj-example into e9ee56a on pymc-devs:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants