Removed progressbar.py #1408
Removed progressbar.py #1408
Conversation
|
I do like the idea of removing that code. I'll try it out. |
|
I like |
|
I think it looks fine. I wonder, though, if we should have it as a dependency, or integrate it as a submodule. |
| eta = (self.iterations / sps) - elapsed | ||
| its = self.iterations | ||
|
|
||
| prog_str = "[{bar}] {it} of {its} in {s_elapsed} sec. " \ |
There was a problem hiding this comment.
SPS and ETA are kinda nice metrics though. Is there now way to get that with tqdm?
There was a problem hiding this comment.
Yeah! Some sample output:
test_disaster_model (pymc3.tests.test_examples.TestDisasterModel) ...
Applied log-transform to early_mean and added transformed early_mean_log_ to model.
Applied log-transform to late_mean and added transformed late_mean_log_ to model.
Assigned Metropolis to switchpoint
32%|███████████████████████▎ | 15969/50000 [00:15<00:33, 1016.85it/s]
in the brackets at the end are [time spent < ETA, SPS it/s]. This can all be customized. I did manual checks with examples in a notebook, ipython shell, and from the command line, with similar results. There are fancy jupyter notebook widgets that can be used, but the base functionality is fine.
There was a problem hiding this comment.
Neat. I think we should just add this as a dependency then.
|
Would be cool if it used the JS version when run inside an NB. Would also be cool to have parallel progress bar if we're sampling in parallel. |
|
It's slightly worrying that this package hasn't been updated in three years. |
|
They do seem active on their github: https://github.com/tqdm/tqdm/commits/master Maybe we can ask them for a new release. |
|
FWIW, I've used it before, so it's at least somewhat widely used... |
|
There's also a conda package on conda-forge, which could be useful for some. |
|
Seems like 4.8.4 was released Aug 18 https://github.com/tqdm/tqdm/releases @fonnesbeck where do you get that number from? |
|
Original library is https://github.com/noamraph/tqdm, but the top issue On Wed, Sep 28, 2016 at 3:33 PM Thomas Wiecki notifications@github.com
|
|
Sorry, yes, I was looking at the original repo. Strange that it comes up first on Google search. |
6 participants
This increases dependence on external libraries, but saves us from maintaining a progress bar. Uses the https://github.com/tqdm/tqdm library, which is pretty heavily used/maintained.
Will close whichever of this or #1407 does not get merged.