Skip to content

Changed check for non-positive support to check for negative support #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 26, 2016
Merged

Changed check for non-positive support to check for negative support #1482

merged 3 commits into from
Oct 26, 2016

Conversation

fonnesbeck
Copy link
Member

Rather than checking for support at zero, this checks for support of a very small negative value (-1e-6).

@fonnesbeck fonnesbeck mentioned this pull request Oct 25, 2016
Merged
@fonnesbeck fonnesbeck merged commit 96093c6 into master Oct 26, 2016
@twiecki twiecki deleted the assert_negative branch October 29, 2016 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@springcoil springcoil springcoil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fonnesbeck @springcoil