Skip to content

Conversation

hvasbath
Copy link
Contributor

@hvasbath hvasbath commented Nov 7, 2016

No description provided.

Copy link
Member

@ColCarroll ColCarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but cmap=None can turn into a kwarg.

Copy link
Member

@ColCarroll ColCarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- I think setting extent in kde2plot_op is funny. That is, I think (but haven't checked) it is being set to be what it would be anyways, and it will definitely throw a TypeError if a user tries to pass extent kwargs. I also think that that's an edge case if you'd rather not fix it now, and you might just add an issue to fix later.

@ColCarroll ColCarroll merged commit 2fb658a into pymc-devs:master Nov 7, 2016
@hvasbath
Copy link
Contributor Author

hvasbath commented Nov 7, 2016

Yeah I was not so sure about it, as it was initially coded by someone else, maybe that developer had something in mind...?

@ColCarroll
Copy link
Member

Yeah, and it is helpful to keep commits small-ish. I opened #1507 to double check this (I can after work, unless you want to get to it first). I could imagine setting it is non-trivial (there's some raveling going on), but there should at least be a manual override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants